Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge community fork package #3

Merged
merged 3 commits into from
Apr 24, 2015
Merged

Merge community fork package #3

merged 3 commits into from
Apr 24, 2015

Conversation

dlwyatt
Copy link
Contributor

@dlwyatt dlwyatt commented Apr 17, 2015

No description provided.

dlwyatt added 3 commits April 17, 2015 16:40
From PowerShell.org fork:  Users of the resource can specify validation parameters based on the file's expected hash, digital signature, or both.

New:  Original Package and xPackage resources were setting the ServerCertificateValidationCallback property to {$true}, which may as well just be labelled "making malicious websites' jobs easy."

The resource now uses default behavior, refusing self-signed or otherwise invalid certificates.  Users can specifiy their own script block for the new ServerCertificateValidationCallback property, if they so choose.  (And they can be more secure about it, such as pinning a specific self-signed certificate by its thumbprint, etc.)

To do:

- Figure out how to test this stuff in Pester.  I've tested it manually, but we need a running web server to test this.  Maybe find something we can kick off from the command line locally in the tests, rather than relying on IIS.
- Add examples for usage of the new properties.
@vors
Copy link
Contributor

vors commented Apr 21, 2015

CLA verified.

vors added a commit that referenced this pull request Apr 24, 2015
@vors vors merged commit d1b15c6 into dsccommunity:dev Apr 24, 2015
mhendric added a commit to mhendric/xPSDesiredStateConfiguration that referenced this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants